[PATCH] D151932: Add dsymutil dwarf5 tests for darwin
Felipe de Azevedo Piovezan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 2 05:50:18 PDT 2023
fdeazeve added a comment.
Thanks for adding more tests!
I have two high level questions:
1. Are the `standard_opcode_lengths` CHECKs relevant for what we are trying to test here?
2. Is the traditional approach for dsymutil tests to have a YAML object file? I see that the same directory has tests that assemble an object file from `.ll` files (by calling `llc`) and also tests that assembly an object file from assembly (`.s`) by calling `llvm-mc`. Both seem shorter / easier to follow, but I have never looked much into those tests.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151932/new/
https://reviews.llvm.org/D151932
More information about the llvm-commits
mailing list