[PATCH] D150482: [AArch64] Don't use tbl lowering if ZExt can be folded into user.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 2 04:51:56 PDT 2023
fhahn marked an inline comment as done.
fhahn added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14461
auto DstWidth = cast<IntegerType>(DstTy->getElementType())->getBitWidth();
+ if (DstWidth % 8 != 0 || DstWidth <= 16 || DstWidth >= 64)
+ return false;
----------------
efriedma wrote:
> Maybe just explicitly check "DstWidth != 16 && DstWidth != 32"?
The current codegen also works for like `i24` and there are existing tests for that; I left the check as is for now to avoid changing behavior unrelated to the patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150482/new/
https://reviews.llvm.org/D150482
More information about the llvm-commits
mailing list