[PATCH] D147547: [AMDGPU] Add buffer intrinsics that take resources as pointers

Fri Jun 2 02:53:50 PDT 2023

piotr added a comment.

LGTM with a nit, but please wait for Matt's approval.

I also did some extra sanity testing and verified that all your three outstanding patches are NFC for the graphics workloads.

================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.h:256-257

+  // Convert the i128 that a addrspace(8) pointer is natively represented as
+  // into the v4i32 that all the buffer intrinsics expent to receive. We can't
+  // add register classes for i128 on pain of the promotion logic going haywire,
----------------
piotr wrote:
> a addrspace -> an addrspace ?
> expent -> expect
expct -> expect

(no need to re-submit to phab just for that)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147547/new/

https://reviews.llvm.org/D147547