[PATCH] D151981: [AArch64] Complete the list of extensions supported by .arch and .arch_extension

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 2 02:48:47 PDT 2023


mstorsjo created this revision.
mstorsjo added reviewers: c-rhodes, SjoerdMeijer, DavidSpickett, lenary, ab.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: LLVM.

This brings the list of extensions supported here up to date
with what is supported by current git versions of binutils.

Also add a comment to AArch64TargetParser to remind people to
consider adding new ones to the list supported in assembly.

In the case of the "rdma" extension, there's a slight surprise:
LLVM knows of the extension under the name "rdm", while binutils
has it named "rdma". However, binutils appears to accept any
abbreviated prefix of an arch extension, so it does accept the
form "rdm" too even if it formally considers it called "rdma".

Thus common use of it might end up calling it "rdm" and having
that working with binutils. (If such cases are common I guess
we could consider adding "rdm" as an alias here too?)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D151981

Files:
  llvm/include/llvm/TargetParser/AArch64TargetParser.h
  llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
  llvm/test/MC/AArch64/directive-arch_extension.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151981.527789.patch
Type: text/x-patch
Size: 3193 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230602/614fee54/attachment.bin>


More information about the llvm-commits mailing list