[PATCH] D151424: [CodeGen] Make use of MachineInstr::all_defs and all_uses. NFCI.

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

> It looks like this causes a major compile-time regression: https://llvm-compile-time-tracker.com/compare.php?from=2de54b919ba5fd9ccf37038cddfc36e97eb480af&to=5022fc2ad31b5e3211e2458347c89412b8c5ec1b&stat=instructions:u

Could you please add https://github.com/jayfoad/llvm-project to the compile time tracker?

> The implementation of these methods looks somewhat suspect: https://github.com/llvm/llvm-project/blob/7f374b6902fad9caed41284a57d573abe9ada9d1/llvm/include/llvm/CodeGen/MachineInstr.h#L732 Not sure why this is creating an `std::function`.

That was part of my attempt at getting sane(ish) declared return types for the new functions. The first versions of this patch used `auto` and did not use `std::function`. What's so bad about `std::function` anyway?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151424/new/

https://reviews.llvm.org/D151424