[PATCH] D151977: [X86][NFC]Use ref instead copy in for loop for SDValue::op_values()

Wang, Xin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 2 00:25:58 PDT 2023


XinWang10 added a comment.

In D151977#4390081 <https://reviews.llvm.org/D151977#4390081>, @goldstein.w.n wrote:

> It should be const ref I think. But 16 byte by value is usually reasonably efficient

Thanks for pointing! I'm interested in where the info '16 byte' from, actually I searched for some while but didn't get useful info. I used to think that 8 byte could be reasonable because it can be fit in internal type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151977/new/

https://reviews.llvm.org/D151977



More information about the llvm-commits mailing list