[PATCH] D151977: [X86][NFC]Use ref instead copy in for loop for SDValue::op_values()

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 23:47:38 PDT 2023


craig.topper added a comment.

We pass SDValue by value all over the SelectionD
AG code. And it looks pretty easy for a compiler to see the unsigned field is unused. Does this change really make a difference?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151977/new/

https://reviews.llvm.org/D151977



More information about the llvm-commits mailing list