[PATCH] D151870: [ARM] Increase cost of unaligned double and float loads

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Sounds good. Remember to upload with context! Other than adding a few extra tests this LGTM.



================
Comment at: llvm/test/Analysis/CostModel/ARM/load_store.ll:73
 ; CHECK-MVE-NEXT:  Cost Model: Found an estimated cost of 1 for instruction: store float undef, ptr undef, align 4
-; CHECK-MVE-NEXT:  Cost Model: Found an estimated cost of 1 for instruction: store double undef, ptr undef, align 4
+; CHECK-MVE-NEXT:  Cost Model: Found an estimated cost of 6 for instruction: store double undef, ptr undef, align 4
 ; CHECK-MVE-NEXT:  Cost Model: Found an estimated cost of 18 for instruction: store <2 x i8> undef, ptr undef, align 1
----------------
It might be worth adding a test with an alignment of 8 to be sure the cost remains OK. And add an unaligned float test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151870/new/

https://reviews.llvm.org/D151870