[PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 21:39:03 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/lib/Demangle/Demangle.cpp:49
 bool llvm::nonMicrosoftDemangle(const char *MangledName, std::string &Result) {
+  if (!MangledName)
+    return false;
----------------
Why is this change? The original contract is that `MangledName` must be non-null.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151003/new/

https://reviews.llvm.org/D151003



More information about the llvm-commits mailing list