[PATCH] D140528: [msan] Add msan support for loongarch64

[WÁNG Xuěruì via Phabricator via llvm-commits]

xen0n added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:5879
+  else if (TargetTriple.getArch() == Triple::loongarch64)
+    return new VarArgLoongArch64Helper(Func, Msan, Visitor);
   else if (TargetTriple.getArch() == Triple::ppc64 ||
----------------
Ami-zhang wrote:
> vitalybuka wrote:
> > it looks like exact copy of VarArgMIPS64Helper
> > why not "new VarArgMIPS64Helper"?
> Yes, `VarArgLoongArch64Helper` is here based on Mips.
> I will verify whether there is any difference in the implementations regarding `vararg` between the two ABI later, and then add VarArgHelper for LoongArch in a separate patch.
In reality LoongArch's ABI is much more similar to that of RISCV than Mips. You may want to double-check that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140528/new/

https://reviews.llvm.org/D140528