[PATCH] D151774: [LICM] Don't hoist threadlocals within presplit coroutines

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 19:13:11 PDT 2023


ChuanqiXu marked an inline comment as done.
ChuanqiXu added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:1228
+        CI->getFunction()->isPresplitCoroutine())
+      return false;
+
----------------
nikic wrote:
> Why is this specific to threadlocal_address? Don't you have the same problem with all readnone/readonly functions, which might be based on thread-local state internally?
Oh, sorry. This was an oversight.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151774/new/

https://reviews.llvm.org/D151774



More information about the llvm-commits mailing list