[PATCH] D151562: [ValueTracking] Remove ORE argument (NFC-ish)

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 15:09:13 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:956-973
-  // If assumptions conflict with each other or previous known bits, then we
-  // have a logical fallacy. It's possible that the assumption is not reachable,
-  // so this isn't a real bug. On the other hand, the program may have undefined
-  // behavior, or we might have a bug in the compiler. We can't assert/crash, so
-  // clear out the known bits, try to warn the user, and hope for the best.
-  if (Known.Zero.intersects(Known.One)) {
     Known.resetAll();
----------------
Seems like something that should go in the lint pass 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151562/new/

https://reviews.llvm.org/D151562



More information about the llvm-commits mailing list