[PATCH] D151933: [DebugInfo] Return an error from DWARFUnitHeader::applyIndexEntry

[Alex Langford via Phabricator via llvm-commits]

bulbazord added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:358
+        errc::invalid_argument,
+        "DWARF package unit at offset 0x%8.8" PRIx64
+        " has a non-zero abbreviation offset prior to applying an index entry",
----------------
aprantl wrote:
> Are these actually specific to DWP files or should the error messages be more generic?
These error messages are inspired by the equivalent ones in LLDB, but I'm not entirely sure. My understanding is that this code only executes in the context of DWO, so if it's specific to DWP I wouldn't be surprised. Maybe somebody else can chime in and give some better context.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151933/new/

https://reviews.llvm.org/D151933