[PATCH] D151774: [LICM] Don't hoist threadlocals within presplit coroutines

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 12:27:52 PDT 2023


nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:1228
+        CI->getFunction()->isPresplitCoroutine())
+      return false;
+
----------------
Why is this specific to threadlocal_address? Don't you have the same problem with all readnone/readonly functions, which might be based on thread-local state internally?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151774/new/

https://reviews.llvm.org/D151774



More information about the llvm-commits mailing list