[PATCH] D127115: [DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2451
+         BinOpcode == ISD::SRL) &&
+        (Sel.getOpcode() == ISD::TRUNCATE ||
+         Sel.getOpcode() == ISD::ZERO_EXTEND) &&
----------------
deadalnix wrote:
> RKSimon wrote:
> > nikic wrote:
> > > For truncates, don't we need to make sure no significant bits of the shamt get truncated?
> > Yes, we should probably drop this change from the patch, accept the regression and address it in a followup
> Fair enough.
I extracted this into D151916


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115