[PATCH] D149675: [Demangle] convert itaniumDemangle and nonMicrosoftDemangle to use std::string_view
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 1 10:54:22 PDT 2023
nickdesaulniers accepted this revision.
nickdesaulniers added inline comments.
================
Comment at: llvm/lib/Demangle/Demangle.cpp:31
std::string Result;
const char *S = MangledName.c_str();
----------------
nickdesaulniers wrote:
> I guess `S` is now unnecessary and can be removed.
Nvm/not yet. `microsoftDemangle` needs to be converted to use `std::string_view` first.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149675/new/
https://reviews.llvm.org/D149675
More information about the llvm-commits
mailing list