[PATCH] D151858: [TargetLowering][ARM][AArch64] Remove usage of NoSignedWrap/NoUnsignedWrap from AVGFLOOR/CEIL transform.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 1 10:54:00 PDT 2023
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM with one possible minor
================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:1040
+ if (IsSigned) {
+ if (DAG.computeOverflowForSignedAdd(Add.getOperand(0),
+ Add.getOperand(1)) ==
----------------
I added DAG::computeOverflowForAdd wrapper to allow us to merge Signed/Unsigned paths - not sure if its useful here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151858/new/
https://reviews.llvm.org/D151858
More information about the llvm-commits
mailing list