[PATCH] D151803: [GlobalIsel][X86] Legalize G_BSWAP II

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 10:42:36 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/X86/GlobalISel/legalize-bswap.mir:9
 ---
 name:            test_bswaps17
 body:             |
----------------
I think something went wrong with the latest diff.

Anyway, you need a non-power-of-2 test in-between the clamped range. That's the case which wouldn't be caught if you dropped the widenScalarToNextPow2 part 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151803/new/

https://reviews.llvm.org/D151803



More information about the llvm-commits mailing list