[PATCH] D127115: [DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

I think you can just go ahead and land this. At this point it doesn't seem like this is going to cause systematic regressions -- and for individual cases we can fix forward.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2451
+         BinOpcode == ISD::SRL) &&
+        (Sel.getOpcode() == ISD::TRUNCATE ||
+         Sel.getOpcode() == ISD::ZERO_EXTEND) &&
----------------
For truncates, don't we need to make sure no significant bits of the shamt get truncated?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115