[PATCH] D127115: [DAGCombine] Make sure combined nodes are added back to the worklist in topological order.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 1 07:37:45 PDT 2023
RKSimon added a subscriber: nikic.
RKSimon added a comment.
I think the next step for this patch is to decide how to get it committed, I'm expecting there will be a few perf regressions that the current tests miss (or only vaguely hint at), but IMO these are grossly outweighed by the benefits we're seeing.
But I'm worried it will end up being stuck in a reversion/re-commit loop for every report.
Does anyone else have any thoughts on this? @foad @nikic @craig.topper ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127115/new/
https://reviews.llvm.org/D127115
More information about the llvm-commits
mailing list