[PATCH] D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 07:07:19 PDT 2023


amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:4814
   LLVM_DEBUG(MI.dump());
   return true;
 }
----------------
A question I had: Does this function also require a call to `recomputeLivenessFlags` after PostRA?


================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:134
 
+  // A number of transformations will elminate the definition of a register
+  // as all of its uses will be removed. However, this leaves a register
----------------
Typo:


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133103/new/

https://reviews.llvm.org/D133103



More information about the llvm-commits mailing list