[PATCH] D151659: Constant propogation through freeze instruction

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 06:32:24 PDT 2023 

nikic reopened this revision.
nikic added a comment.
This revision is now accepted and ready to land.

Reverted due to buildbot failure:

  FAILED: lib/TableGen/CMakeFiles/LLVMTableGen.dir/SetTheory.cpp.o
  CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D_LIBCPP_ENABLE_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/lib/TableGen -I/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/TableGen -I/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/include -I/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/include -nostdinc++ -isystem /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/libcxx_build_ubsan/include -isystem /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/libcxx_build_ubsan/include/c++/v1 -fsanitize=undefined -Wl,--rpath=/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/libcxx_build_ubsan/lib -L/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/libcxx_build_ubsan/lib -w -stdlib=libc++ -fPIC -fno
   -semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-class-memaccess -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fno-omit-frame-pointer -gline-tables-only -fsanitize=undefined -fno-sanitize=vptr,function -fno-sanitize-recover=all -fsanitize-blacklist=/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/sanitizers/ubsan_ignorelist.txt -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/TableGen/CMakeFiles/LLVMTableGen.dir/SetTheory.cpp.o -MF lib/TableGen/CMakeFiles/LLVMTableGen.dir/SetTheory.cpp.o.d -o lib/TableGen/CMakeF
   iles/LLVMTableGen.dir/SetTheory.cpp.o -c /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/TableGen/SetTheory.cpp
  clang++: /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/Transforms/Utils/SCCPSolver.cpp:442: llvm::ValueLatticeElement &llvm::SCCPInstVisitor::getValueState(llvm::Value *): Assertion `!V->getType()->isStructTy() && "Should use getStructValueState"' failed.
  PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
  Stack dump:
  0.      Program arguments: /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang++ -fsanitize=undefined -L/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/libcxx_build_ubsan/lib -w -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-class-memaccess -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fno-omit-frame-pointer -gline-tables-only -fsanitize=undefined -fno-sanitize=vptr,function -fno-sanitize-recover=all -fsanitize-blacklist=/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/sanitizers/ubsan_ignorelist.txt -ffunction-sections -fdata-sections -O3 -fno-exceptions -funwind-tables -fno-rtt
   i -std=c++17 -fdiagnostics-color -Wl,--rpath=/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/libcxx_build_ubsan/lib -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D_LIBCPP_ENABLE_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/lib/TableGen -I/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/TableGen -I/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/include -I/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/include -nostdinc++ -isystem /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/libcxx_build_ubsan/include -isystem /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/libcxx_build_ubsan/include/c++/v1 -stdlib=libc++ -DNDEBUG -UNDEBUG -c -MD -MT lib/TableGen/CMakeFiles/LLVMTableGen.dir/SetTheory.cpp.o -MF lib/TableGen/CMakeFiles/LLVMTableGen.dir/SetTheory.cpp.o.d -fcolor-diagnostics -o lib/TableGen/CMakeFiles/LL
   VMTableGen.dir/SetTheory.cpp.o /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/TableGen/SetTheory.cpp
  1.      <eof> parser at end of file
  2.      Optimizer
   #0 0x0000aaaad4f56648 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x7606648)
   #1 0x0000aaaad4f547a8 llvm::sys::RunSignalHandlers() (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x76047a8)
   #2 0x0000aaaad4ec6ab4 CrashRecoverySignalHandler(int) CrashRecoveryContext.cpp:0:0
   #3 0x0000ffffb1d768bc (linux-vdso.so.1+0x8bc)
   #4 0x0000ffffb18610c0 (/lib/aarch64-linux-gnu/libc.so.6+0x810c0)
   #5 0x0000ffffb181ab2c raise (/lib/aarch64-linux-gnu/libc.so.6+0x3ab2c)
   #6 0x0000ffffb18074bc abort (/lib/aarch64-linux-gnu/libc.so.6+0x274bc)
   #7 0x0000ffffb1814434 (/lib/aarch64-linux-gnu/libc.so.6+0x34434)
   #8 0x0000ffffb181449c (/lib/aarch64-linux-gnu/libc.so.6+0x3449c)
   #9 0x0000aaaad62c2634 llvm::SCCPInstVisitor::getValueState(llvm::Value*) SCCPSolver.cpp:0:0
  #10 0x0000aaaad62c5664 llvm::SCCPInstVisitor::visitFreezeInst(llvm::FreezeInst&) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x8975664)
  #11 0x0000aaaad62c9a8c llvm::SCCPInstVisitor::solve() (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x8979a8c)
  #12 0x0000aaaad63b56ec llvm::SCCPPass::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x8a656ec)
  #13 0x0000aaaad49cf3ac llvm::PassManager<llvm::Function, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x707f3ac)
  #14 0x0000aaaad40c5bd0 llvm::CGSCCToFunctionPassAdaptor::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x6775bd0)
  #15 0x0000aaaad40c0b80 llvm::PassManager<llvm::LazyCallGraph::SCC, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x6770b80)
  #16 0x0000aaaad40c41a8 llvm::DevirtSCCRepeatedPass::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x67741a8)
  #17 0x0000aaaad40c2960 llvm::ModuleToPostOrderCGSCCPassAdaptor::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x6772960)
  #18 0x0000aaaad49ce6ac llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x707e6ac)
  #19 0x0000aaaad61e3a88 llvm::ModuleInlinerWrapperPass::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x8893a88)
  #20 0x0000aaaad49ce6ac llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x707e6ac)
  #21 0x0000aaaad564a520 (anonymous namespace)::EmitAssemblyHelper::RunOptimizationPipeline(clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream>>&, std::unique_ptr<llvm::ToolOutputFile, std::default_delete<llvm::ToolOutputFile>>&) BackendUtil.cpp:0:0
  #22 0x0000aaaad56430f4 clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::StringRef, llvm::Module*, clang::BackendAction, llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream>>) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x7cf30f4)
  #23 0x0000aaaad5a45474 clang::BackendConsumer::HandleTranslationUnit(clang::ASTContext&) CodeGenAction.cpp:0:0
  #24 0x0000aaaad7039f5c clang::ParseAST(clang::Sema&, bool, bool) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x96e9f5c)
  #25 0x0000aaaad5963f8c clang::FrontendAction::Execute() (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x8013f8c)
  #26 0x0000aaaad58e8894 clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x7f98894)
  #27 0x0000aaaad5a3f09c clang::ExecuteCompilerInvocation(clang::CompilerInstance*) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x80ef09c)
  #28 0x0000aaaad2d3f560 cc1_main(llvm::ArrayRef<char const*>, char const*, void*) (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build0/bin/clang+++0x53ef560)
  #29 0x0000aaaad2d3b530 ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&, llvm::ToolContext const&) driver.cpp:0:0
  #30 0x0000aaaad57b7b18 void llvm::function_ref<void ()>::callback_fn<clang::driver::CC1Command::Execute(llvm::ArrayRef<std::optional<llvm::StringRef>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>*, bool*) const::$_1>(long) Job.cpp:0:0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151659/new/

https://reviews.llvm.org/D151659

More information about the llvm-commits mailing list