[PATCH] D151795: [DebugInfo] Add DW_ATE_complex_float case to assert in isUnsignedDIType

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp:226
           Encoding == dwarf::DW_ATE_boolean ||
+          Encoding == dwarf::DW_ATE_complex_float ||
           (Ty->getTag() == dwarf::DW_TAG_unspecified_type &&
----------------
MaskRay wrote:
> Whether are the other `Encoding == xxx` tested? Is it possible to group the `DW_ATE_complex_float` test with those test files?
Omitting some types from the assertion and running the tests, among other failures I found `float_const.ll`, `dbg-i128-const.ll`  and `dbg-const-int.ll` in `llvm/test/DebugInfo/X86` (same directory as the new test) which look to be testing this behaviour. Not conclusive but it looks like there's a precedent for using this directory.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151795/new/

https://reviews.llvm.org/D151795