[PATCH] D151276: Weaken MFI Max Call Frame Size Assertion

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 added inline comments.


================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:352
   unsigned MaxCallFrameSize = 0;
   bool AdjustsStack = MFI.adjustsStack();
 
----------------
oskarwirga wrote:
> barannikov88 wrote:
> > This should be initialized to false.
> > There is no difference in practice, but it will be clearer that the flag is recalculated.
> > 
> Interestingly setting this to false causes `CodeGen/X86/asan-check-memaccess-add.ll` to crash :D
Probably it changed from true to false, which could never happen before.
I didn't expect a change in behavior, so feel free to revert this part


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151276/new/

https://reviews.llvm.org/D151276