[PATCH] D151414: [RISCV] Add Zvfhmin extension support for llvm RISCV backend.
Jianjian Guan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 1 00:27:34 PDT 2023
jacquesguan marked an inline comment as done.
jacquesguan added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:184
- if (Subtarget.hasVInstructionsF16())
+ if (Subtarget.hasVInstructionsF16Mininal())
for (MVT VT : F16VecVTs)
----------------
craig.topper wrote:
> craig.topper wrote:
> > Isn't the clang patch have dependent on this?
> I ran the zvfhmin.c from the clang patch through CodeGen and got
>
> ```
> fatal error: error in backend: Scalarization of scalable vectors is not supported.
> ```
>
> The clang patch should be reverted until the CodeGen patch is in.
Yes, I made a mistake on the dependent relationship. Thanks for reverting it.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1017
+ if (VT.getVectorElementType() == MVT::f16 &&
+ !Subtarget.hasVInstructionsF16()) {
----------------
craig.topper wrote:
> This needs to be after `By default everything must be expanded.`
Done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151414/new/
https://reviews.llvm.org/D151414
More information about the llvm-commits
mailing list