[PATCH] D151690: [LoopIdiom] Freeze BitPos if !isGuaranteedNotToBeUndefOrPoison

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 00:15:56 PDT 2023


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:2403
+    else
+      InsertPt = &*DT->getRoot()->getFirstNonPHIOrDbgOrAlloca();
+    FreezeInst *BitPosFrozen =
----------------
Add `if (!InsertPtr) return false;` here, there are some rare edge cases where there is no insertion point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151690/new/

https://reviews.llvm.org/D151690



More information about the llvm-commits mailing list