[PATCH] D151716: [RISCV] check pointer before dereference
Piyou Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 31 21:35:12 PDT 2023
This revision was automatically updated to reflect the committed changes.
Closed by commit rGeabf1d367f66: [RISCV] check pointer before dereference (authored by BeMg).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151716/new/
https://reviews.llvm.org/D151716
Files:
llvm/lib/Support/RISCVISAInfo.cpp
Index: llvm/lib/Support/RISCVISAInfo.cpp
===================================================================
--- llvm/lib/Support/RISCVISAInfo.cpp
+++ llvm/lib/Support/RISCVISAInfo.cpp
@@ -699,9 +699,10 @@
auto StdExtsItr = StdExts.begin();
auto StdExtsEnd = StdExts.end();
- auto GoToNextExt = [](StringRef::iterator &I, unsigned ConsumeLength) {
+ auto GoToNextExt = [](StringRef::iterator &I, unsigned ConsumeLength,
+ StringRef::iterator E) {
I += 1 + ConsumeLength;
- if (*I == '_')
+ if (I != E && *I == '_')
++I;
};
for (auto I = Exts.begin(), E = Exts.end(); I != E;) {
@@ -737,7 +738,7 @@
ExperimentalExtensionVersionCheck)) {
if (IgnoreUnknown) {
consumeError(std::move(E));
- GoToNextExt(I, ConsumeLength);
+ GoToNextExt(I, ConsumeLength, Exts.end());
continue;
}
return std::move(E);
@@ -747,7 +748,7 @@
// Currently LLVM supports only "mafdcvh".
if (!isSupportedExtension(StringRef(&C, 1))) {
if (IgnoreUnknown) {
- GoToNextExt(I, ConsumeLength);
+ GoToNextExt(I, ConsumeLength, Exts.end());
continue;
}
return createStringError(errc::invalid_argument,
@@ -758,7 +759,7 @@
// Consume full extension name and version, including any optional '_'
// between this extension and the next
- GoToNextExt(I, ConsumeLength);
+ GoToNextExt(I, ConsumeLength, Exts.end());
}
// Handle other types of extensions other than the standard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151716.527277.patch
Type: text/x-patch
Size: 1564 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230601/d72e0872/attachment.bin>
More information about the llvm-commits
mailing list