[PATCH] D151276: Weaken MFI Max Call Frame Size Assertion
Oskar Wirga via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 31 20:24:55 PDT 2023
oskarwirga marked an inline comment as not done.
oskarwirga added inline comments.
================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:352
unsigned MaxCallFrameSize = 0;
bool AdjustsStack = MFI.adjustsStack();
----------------
barannikov88 wrote:
> This should be initialized to false.
> There is no difference in practice, but it will be clearer that the flag is recalculated.
>
Interestingly setting this to false causes `CodeGen/X86/asan-check-memaccess-add.ll` to crash :D
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151276/new/
https://reviews.llvm.org/D151276
More information about the llvm-commits
mailing list