[PATCH] D151711: PowerPC/SPE: Grab the emergency slot for the vreg(that was created by the eliminateFramePointer)

Justin Hibbits via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 31 19:03:23 PDT 2023


jhibbits added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:2297
   if (MFI.hasVarSizedObjects() || spillsCR(MF) || hasNonRISpills(MF) ||
-      (hasSpills(MF) && !isInt<16>(StackSize))) {
+      (hasSpills(MF) && [&StackSize, &Subtarget]() -> bool {
+        if (Subtarget.hasSPE())
----------------
Not a fan of including a lambda in a conditional expression.  It makes the expression as a whole harder to read.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151711/new/

https://reviews.llvm.org/D151711



More information about the llvm-commits mailing list