[PATCH] D151755: [DebugInfo] Add error checking around data extraction in DWARFAbbreviationDeclaration::extract

Alex Langford via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 31 16:55:33 PDT 2023


bulbazord updated this revision to Diff 527239.
bulbazord added a comment.

- Add more rigorous testing. Specifically, I'm testing every possible place where we we can bail early from DWARFAbbreviationDeclaration::extract.
- Replace the `writeBadAbbreviationDeclarationData` with more specific functions to handle both malformed input and input that is too large (both kinds of LEB128 extraction errors).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151755/new/

https://reviews.llvm.org/D151755

Files:
  llvm/lib/DebugInfo/DWARF/DWARFAbbreviationDeclaration.cpp
  llvm/unittests/DebugInfo/DWARF/DWARFDebugAbbrevTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151755.527239.patch
Type: text/x-patch
Size: 8028 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230531/6791a35a/attachment.bin>


More information about the llvm-commits mailing list