[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

Wed May 31 16:19:34 PDT 2023

Amir added inline comments.

================
Comment at: bolt/test/CMakeLists.txt:40
   llvm-bolt
-  llvm-boltdiff
   llvm-bolt-heatmap
----------------
We have a number of dependencies on llvm-boltdiff and perf2bolt, e.g. in internal and upstream binary tests: https://github.com/rafaelauler/bolt-tests/blob/main/CMakeLists.txt#L22. Can we keep these targets somehow?

================
Comment at: bolt/tools/heatmap/CMakeLists.txt:8

-add_bolt_tool(llvm-bolt-heatmap
+add_bolt_executable(llvm-bolt-heatmap
   heatmap.cpp
----------------
phosek wrote:
> smeenai wrote:
> > Why this change?
> This tool wasn't previously included in the `bolt` umbrella target so I assume that it doesn't need an install target, but I'd be helpful for @Amir to confirm.
It wasn't included by omission. Let's include it into the umbrella target.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151595/new/

https://reviews.llvm.org/D151595