[PATCH] D149486: [RISCV] Strengthen atomic ordering for sequentially consistent stores

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 31 15:55:25 PDT 2023


paulkirth updated this revision to Diff 527221.
paulkirth added a comment.

Put the trailing fence behind an `experimental` flag.

I'm not sure this is really the best way to go about this. Most of the
"experimental" flags for RISC-V are defined in the tablegen files, but those
are mostly extensions whose entire implementation is experimental, which
doesn't seem to fit well with something that is a fairly minor transform.

Right now the flag also won't be exposed to clang very well. We could add a
module flag and try to plumb this through clang's tablegen, but that also feels
pretty wrong.

If possible I'd appreciate some guidance on the best way to acheive this from
somone with more familiarty with how this should to be done in the RISC-V
backend.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149486/new/

https://reviews.llvm.org/D149486

Files:
  llvm/lib/Target/RISCV/RISCVISelLowering.cpp
  llvm/test/CodeGen/RISCV/atomic-load-store.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149486.527221.patch
Type: text/x-patch
Size: 19074 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230531/793ecb2a/attachment.bin>


More information about the llvm-commits mailing list