[PATCH] D151187: [doc] Add casting style preference to coding standards
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 31 14:06:56 PDT 2023
nikic added a comment.
-1 from my side. I consider `static_cast<>` to be worse for integer casts by dint of adding unnecessary noise. I could get on board with this if integer/enum casts are excluded.
For the cases where it really matters, we already use our own `cast`/`dyn_cast` anyway. Encouraging use of `const_cast<>` is fine as well, and I believe we already do use that fairly consistently in the cases where it is applicable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151187/new/
https://reviews.llvm.org/D151187
More information about the llvm-commits
mailing list