[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo reopened this revision.
oontvoo added a comment.
This revision is now accepted and ready to land.

In D144999#4356218 <https://reviews.llvm.org/D144999#4356218>, @thakis wrote:

> Reverted in 4980eead4d0b4666d53dad07afb091375b3a13a0 <https://reviews.llvm.org/rG4980eead4d0b4666d53dad07afb091375b3a13a0> for now.
>
> (The assert only happens when targeting x86_64, not arm64. The repro script above has the right `-arch` flag to toggle it.)

Thanks for the revert! This was caused by another bug (should be fixed in https://reviews.llvm.org/D151824)
Will reland this once that is landed.



================
Comment at: llvm/lib/MC/MCAsmBackend.cpp:125
+    // Reserving an empty slot for it seems silly.
+    return name == "__gxx_personality_v0" || name == "__objc_personality_v0";
+  }
----------------
need an additional _


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144999/new/

https://reviews.llvm.org/D144999