[PATCH] D149775: [AMDGPU] Reserve SGPR pair when long branches are present

Corbin Robeck via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 31 10:52:37 PDT 2023


crobeck marked an inline comment as done.
crobeck added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:1454
+    // Update reserved registers to include long branch ones
+    MRI.freezeReservedRegs(MF);
+  }
----------------
jrbyrnes wrote:
> Will this ever be called directly after `freezeReservedRegs` for VGPRForAGPRCopy (i.e. on gfx908)? If so, in those cases, can we use `reserveReg` instead of the second `freezeReservedRegs`?
That's a good point. Updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149775/new/

https://reviews.llvm.org/D149775



More information about the llvm-commits mailing list