[PATCH] D151561: [RISCV][InsertVSETVLI] Avoid vmv.s.x SEW toggle if at start of block

Wed May 31 10:26:46 PDT 2023

jrtc27 added a comment.

In D151561#4384717 <https://reviews.llvm.org/D151561#4384717>, @luke wrote:

> In D151561#4384699 <https://reviews.llvm.org/D151561#4384699>, @jrtc27 wrote:
>
>> https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy:
>>
>>> - The commit message for the reverting commit should explain why patch is being reverted.
>
> The separate commits were accidentally squashed together when initially pushed, apologies for the noise

Then say so in the commit message for the revert. Otherwise it's really hard for anyone other than you reading the history, especially way off in the future, to work out what the reason behind the revert was. Missing dependency? Buildbot breakage? Third-party code breakage? Idea just fundamentally wrong? There are lots of possible reasons for reverts.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151561/new/

https://reviews.llvm.org/D151561