[PATCH] D151807: [InstCombine] Revisit user of newly one-use instructions

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/or-shifted-masks.ll:55
 
 define i32 @multiuse1(i32 %x) {
 ; CHECK-LABEL: @multiuse1(
----------------
This is a bit unfortunate, but I believe it's ultimately not a problem. The two lshrs here are the same instruction and will be CSEd, at which point this reduces to the same IR. Similar for the test below.

I double checked the worklist order, and the new one is "more correct" (i.e. follows instruction order more closely), but happens to produce worse results in this instance.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151807/new/

https://reviews.llvm.org/D151807