[PATCH] D149439: [yaml2obj] Add support fot structured section data.

Wed May 31 07:55:50 PDT 2023

jhenderson added inline comments.

================
Comment at: llvm/test/tools/yaml2obj/COFF/section-data.yaml:20
+    VirtualSize:     20
+    Data:
+        - Int32: 1
----------------
I'm not sure I like the term `Data`, given that `SectionData` already exists. I'm guessing renaming `SectionData` to `RawData` is impractical due to the number of YAML files that would invalidate, but regardless, perhaps `StructuredData` might be a better name?

================
Comment at: llvm/test/tools/yaml2obj/COFF/section-data.yaml:25
+        - Int32: 3
+    SectionData: 55555555
+symbols: []
----------------
I'm not convinced both `SectionData` and `Data` should be specifiable for the same section. I think it makes more sense to reject the YAML if both are specified.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149439/new/

https://reviews.llvm.org/D149439