[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 31 07:25:38 PDT 2023
MaskRay added inline comments.
================
Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:195
+ if (!hasV6MOps())
+ llvm_unreachable("Cannot generate execute-only code for this target");
}
----------------
If this code path is actually reachable, a proper error reporting will be better. At the least `report_fatal_error` can be used. Don't use `llvm_unreachable` for known-reachable code paths.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149444/new/
https://reviews.llvm.org/D149444
More information about the llvm-commits
mailing list