[PATCH] D151797: [AMDGPU] WQM: Allow insertion of exact mode transition as terminator

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Missing test updates?



================
Comment at: llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp:1223
   if (SaveWQM) {
-    MI = BuildMI(MBB, Before, DebugLoc(), TII->get(AndSaveExecOpc), SaveWQM)
+    unsigned Opcode = IsTerminator ? AndSaveExecTermOpc : AndSaveExecOpc;
+    MI = BuildMI(MBB, Before, DebugLoc(), TII->get(Opcode), SaveWQM)
----------------
Wouldn’t this need a block split and always use the terminator?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151797/new/

https://reviews.llvm.org/D151797