[PATCH] D151617: A test case for the revision D151616

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 31 04:41:52 PDT 2023


qcolombet accepted this revision.
qcolombet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/Transforms/Reassociate/reassociate-not-from-the-outside-of-the-loop.ll:1
+; RUN: opt -passes=reassociate -S < %s | FileCheck %s
+
----------------
Maybe use `update_test_checks.py` here as well so that the diff will be obvious in your next PR.


================
Comment at: llvm/test/Transforms/Reassociate/reassociate-not-from-the-outside-of-the-loop.ll:30
+  %arrayidx = getelementptr inbounds double, ptr %cells, i64 %idxprom
+  %0 = load double, ptr %arrayidx
+  %mul2 = fmul fast double %mul, %0
----------------
Please run `instnamer` to get rid of the implicit variables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151617/new/

https://reviews.llvm.org/D151617



More information about the llvm-commits mailing list