[PATCH] D149061: [clang] remove dereferencing of invalid pointer

[Ashay Rane via Phabricator via llvm-commits]

ashay-github added a comment.

> Any ideas why I'm not able to reproduce on a non-windows host (and AFAIK that specific test case hasn't been flagged by any build bots)? I would think we should still be able to test the windows demangling scheme on any host.

My apologies for dropping this.  I was out of town when your message arrived.

My hypothesis is that you may have build LLVM in Release configuration (and perhaps the bots build in Release configuration as well).  Our Windows Release builds were passing but the Debug builds failed.  When I looked through the standard library functions in MSVC header files, I found that a vast number of them contained `#ifdef` statements that were predicated on whether the compiler is called with debug flags, with the debug builds containing far more conservative checks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149061/new/

https://reviews.llvm.org/D149061