[PATCH] D107278: [RISCV] Add new lga pseudoinstruction

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/MC/RISCV/rvi-pseudos.s:48
+# CHECK:      .Lpcrel_hi7:
+# CHECK:      auipc a1, %got_pcrel_hi(another_symbol)
+# CHECK-RV32: lw    a1, %pcrel_lo(.Lpcrel_hi7)(a1)
----------------
jrtc27 wrote:
> MaskRay wrote:
> > Add `-NEXT` for both `auipc` and `lw`/`ld`. It gives the user a hint that the instructions are contiguous. Also, in case of an failure, the FileCheck diagnostic will be more useful. 
> Hm, I'd rather stick with the style of the existing checks... but you're right using -NEXT for all these would be better
Ok, I don't stress this too much. If you want to change existing patterns to use `-NEXT:`, that's fine as well:)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107278/new/

https://reviews.llvm.org/D107278