[PATCH] D145698: [IR][Legalizations] Widen illegal deinterleave and interleave vectors

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:5020
   }
-
   assert(!WidenVT.isScalableVector() &&
----------------
Unrelated change?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:5733
+  if (getTypeAction(WidenVec.getValueType()) == TargetLowering::TypeWidenVector)
+    WidenVec = GetWidenedVector(WidenVec);
+
----------------
GetWidenedVector does a map lookup, but there's no way WidenVec could be in the map. Won't this fail?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145698/new/

https://reviews.llvm.org/D145698