[PATCH] D151614: [BOLT] Align BranchInfo and FuncBranchData in DataAggregator::recordTrace

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 30 16:23:22 PDT 2023


rafauler accepted this revision.
rafauler added a comment.
This revision is now accepted and ready to land.

LGTM with nits



================
Comment at: bolt/lib/Profile/DataAggregator.cpp:905
 
-    // Record fall-through jumps
-    BinaryBasicBlock::BinaryBranchInfo &BI = BB->getBranchInfo(*NextBB);
-    BI.Count += Count;
-
     if (Branches) {
       const MCInst *Instr = BB->getLastNonPseudoInstr();
----------------
Remove this check and assert at function start that Branches is never nullpr? Since now you're relying on branches being non-null..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151614/new/

https://reviews.llvm.org/D151614



More information about the llvm-commits mailing list