[PATCH] D151595: [BOLT][CMake] Avoid duplicating standard install targets
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 30 16:22:35 PDT 2023
smeenai added a comment.
Hmm, could we extend the existing umbrella target support for things like llvm-libraries and clang-libraries to cover the BOLT case as well?
================
Comment at: bolt/tools/driver/CMakeLists.txt:46
+ if(TARGET install-${target})
+ add_custom_target(install-bolt install-${target})
+ endif()
----------------
I assume this should be add_dependencies?
================
Comment at: bolt/tools/driver/CMakeLists.txt:49
+ if(TARGET install-${target}-stripped)
+ add_custom_target(install-bolt-stripped install-${target})
+ endif()
----------------
This should depend on the stripped target?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151595/new/
https://reviews.llvm.org/D151595
More information about the llvm-commits
mailing list