[PATCH] D151663: [RISCV] Implement support for bf16 truncate/extend on hard FP targets
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 30 16:22:27 PDT 2023
craig.topper added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4825
+ Op.getOperand(0),
+ DAG.getShiftAmountConstant(16, Subtarget.getXLenVT(), DL));
+ SDValue Res = Subtarget.is64Bit()
----------------
I think XLenVT here here should be `Op.getOperand(0).getValueType()` which probably is XLenVT, but it looks better to use the same VT for both.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151663/new/
https://reviews.llvm.org/D151663
More information about the llvm-commits
mailing list