[PATCH] D150641: [bazel] Refactor entries in WORKSPACE to bzl files
Geoffrey Martin-Noble via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 30 15:51:08 PDT 2023
GMNGeoffrey added a comment.
In D150641#4378530 <https://reviews.llvm.org/D150641#4378530>, @matts1 wrote:
> I hadn't considered this up until now. I was just assuming that users would still use the same method described in examples (which this change doesn't break - it still works). However, you raise a good point, so I've changed it to work the same way as most other repos (load the @<repo>, then call <repo>_deps to load the dependencies, then call <repo>_repos to execute our repo rules. This should make it much easier to load, but I'll leave that to a future CL.
I think the examples were actually already broken by the previous patches in this area. You now have to manually configure `zlib` and `zstd`. They currently "work" because they're still pointing at an old version of the repo.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150641/new/
https://reviews.llvm.org/D150641
More information about the llvm-commits
mailing list