[PATCH] D151457: [TableGen] Add !getdagargs and !getdagnames

Michael Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 30 13:27:15 PDT 2023


hliao added a comment.

In D151457#4380793 <https://reviews.llvm.org/D151457#4380793>, @fpetrogalli wrote:

> Hey @hliao  - thank you for this patch. Apparently we had a similar idea D151702 <https://reviews.llvm.org/D151702> :)
>
> I just have a couple of comments.
>
> Thanks!
>
> Francesco

I proposed another change introducing `!getdagarg` and `!getdagname` to access individual arguments instead of a list of them. Personally, I thought that should be more convenient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151457/new/

https://reviews.llvm.org/D151457



More information about the llvm-commits mailing list