[PATCH] D151561: [RISCV][InsertVSETVLI] Avoid vmv.s.x SEW toggle if at start of block

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 30 13:24:29 PDT 2023


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/comment addressed.



================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:1383
     }
 
     Register VRegDef = MI.getOperand(0).getReg();
----------------
For staging only, please add a bit of code to force SEWMax to SEQEqual here.  The resulting change should be fully NFC with that added.  Please confirm that before landing.

At your option, you could land the NFC form of the change, and then land a change which removes the bailout and the adds the test changes.  I'd probably structure it that way myself, but it's not a strict requirement.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151561/new/

https://reviews.llvm.org/D151561



More information about the llvm-commits mailing list